Github user kkolinko commented on the issue:

    https://github.com/apache/tomcat/pull/121
  
    1. This does not conform to code style. The "echo off" command and license 
header are missing.
    2. This approach is naive and does not work. The "shutdown.bat" script does 
not stop Tomcat! It just commands Tomcat to stop. The shutting down may take 
some time.
    3. A rather rare use case.
    If one is developing, I think an IDE should know how restart Tomcat (e.g. 
Eclipse IDE knows how to do it and how to stop Tomcat process forcefully if it 
does not shut down in time). 
    
    Thus I am -1 on merging this.
    
    4. IMHO, the proper place to file enhancement requests is Bugzilla, so that 
they can be referenced in changelog.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to