On 10/3/2018 12:05 PM, Mark Thomas wrote:
[4]
https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196
That one I do think makes sense to pull into JrePlatform.
I have moved [4] above in r1842748. I used the existing convention in
the file of setting the string to a static variable, i.e.
private static final String OS_NAME_WINDOWS_PREFIX = "Windows";
+ private static final String OS_NAME_MAC_OS_LC_PREFIX = "mac os x";
though I personally think that it would make sense to inline it since
it's only used once.
It would also mean fewer lines of code - always a winner in my book ;)
'nuff said - r1842751
To be honest, I have no strong feelings one way or the other. It is a
style choice more than anything else in this case. It isn't an itch I
want to scratch but equally I'm not going to object if you want to make
that change.
To itch his own ;)
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
