On Wed, Nov 7, 2018 at 12:17 AM Rémy Maucherat <r...@apache.org> wrote:
> On Tue, Nov 6, 2018 at 6:39 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> > , and the javadoc says: If any execution of the task encounters an >> > exception, subsequent executions are suppressed. >> > >> > So you think adding back the scheduling after a problem is better >> > ? >> >> Yes, I think so. The container should protect itself from >> applications, and this is a case where a misbehaving application can >> break the correct operation of the container. >> > > Ok, so it's harder, there's no API for it. I'll try to find a good > solution. > Done for ContainerBase, it now uses another scheduled task to check the state of the first one and looks clean IMO (a lot better as if there was similar code attempting the same thing pre refactoring). It's probably difficult to try to make the added code generic (it may need to check for conditions, may use a different scheduling, etc) although I still might attempt it at some point (although not as significant as this one, the other scheduled tasks in Tomcat would be better off with a "raise dead" capability). Rémy