Author: markt Date: Wed Nov 21 14:05:26 2018 New Revision: 1847104 URL: http://svn.apache.org/viewvc?rev=1847104&view=rev Log: Use the trimmed value for the remainder of the method as originally intended. NO-OP code reported by SpotBugs
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=1847104&r1=1847103&r2=1847104&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Wed Nov 21 14:05:26 2018 @@ -382,7 +382,7 @@ public final class CGIServlet extends Ht if (getServletConfig().getInitParameter("cgiMethods") != null) { String paramValue = getServletConfig().getInitParameter("cgiMethods"); - paramValue.trim(); + paramValue = paramValue.trim(); if ("*".equals(paramValue)) { cgiMethodsAll = true; } else { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org