Author: markt
Date: Wed Nov 21 15:36:51 2018
New Revision: 1847119
URL: http://svn.apache.org/viewvc?rev=1847119&view=rev
Log:
More false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1847119&r1=1847118&r2=1847119&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Wed Nov 21 15:36:51
2018
@@ -542,6 +542,13 @@
<Bug pattern="IS2_INCONSISTENT_SYNC"/>
</Match>
<Match>
+ <!-- This could be optimised but a) the code would be less clear and -->
+ <!-- b) SpotBugs still reports an error with the optimised code. -->
+ <Class name="org.apache.catalina.tribes.group.GroupChannel"/>
+ <Method name="startHeartbeat"/>
+ <Bug pattern="RpC_REPEATED_CONDITIONAL_TEST "/>
+ </Match>
+ <Match>
<Class name="org.apache.catalina.tribes.group.RpcChannel"/>
<Method name="send"/>
<Bug pattern="WA_NOT_IN_LOOP"/>
@@ -709,6 +716,13 @@
<Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER" />
</Match>
<Match>
+ <!-- This could be optimised but a) the code would be less clear and -->
+ <!-- b) SpotBugs still reports an error with the optimised code. -->
+ <Class name="org.apache.coyote.AbstractProtocol"/>
+ <Method name="startAsyncTimeout"/>
+ <Bug pattern="RpC_REPEATED_CONDITIONAL_TEST "/>
+ </Match>
+ <Match>
<!-- Correct behaviour does not assume sequential operations on concurrent
hash map are atomic. -->
<Class name="org.apache.coyote.AbstractProtocol$AbstractConnectionHandler"
/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
