https://bz.apache.org/bugzilla/show_bug.cgi?id=63195
Bug ID: 63195
Summary: Add easy way to test RemoteIpValve works properly
Product: Tomcat 8
Version: 8.5.34
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: micha...@apache.org
Target Milestone: ----
Sometimes you don't know whether the valve is properly working. You always need
to write custom code to check that, e.g., I did this:
> public class RemoteIpTesterServlet extends HttpServlet {
>
> private static final long serialVersionUID = 1L;
>
> @Override
> protected void doGet(HttpServletRequest req, HttpServletResponse resp)
> throws ServletException, IOException {
> PrintWriter pw = resp.getWriter();
> pw.print("request.remoteAddr: ");
> pw.println(req.getRemoteAddr());
> pw.print("request.remotePort: ");
> pw.println(req.getRemotePort());
> pw.print("request.header['x-forwarded-for']: ");
> pw.println(req.getHeader("X-Forwarded-For"));
> pw.print("request.header['x-forwarded-host']: ");
> pw.println(req.getHeader("X-Forwarded-Host"));
> pw.print("request.header['x-forwarded-proto']: ");
> pw.println(req.getHeader("X-Forwarded-Proto"));
> pw.print("request.scheme: ");
> pw.println(req.getScheme());
> pw.print("request.secure: ");
> pw.println(req.isSecure());
> pw.print("request.serverName: ");
> pw.println(req.getServerName());
> pw.print("request.serverPort: ");
> pw.println(req.getServerPort());
> }
> }
>
People are over and over reinventing the wheel. We could solve this in two
ways:
By adding a org.apache.catalina.servlets: RemoteIpTesterServlet or some status
mountpoint to RemoveIpValve which will instead of invoking getNext().invoke()
print this information to the response.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
