toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473394845 Thanks for taking the time to look at my changes! I totally missed the code dealing with dynamic reconfiguration through JMX. I changed my code to keep the old behaviour (pool cleaner is only started when timeBetweenEvictionRunsMillis > 0) and added documentation to maxAge pointing out that the age of idle connections will only be checked if both maxAge and timeBetweenEvictionRunsMillis are set. I also adjusted ConnectionPool#checkPoolConfiguration() to set timeBetweenEvictionRunsMillis=maxAge in case that timeBetweenEvictionRunsMillis>maxAge (because otherwise the maxAge cannot be guaranteed). setMaxAge() now calls both checkPoolConfiguration() and a new poolCleanerAttributeUpdated() method where I moved all the duplicated "start/stop pool cleaner if necessary" code to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
