isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850076 I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with `false` value and only set to `true` upon success, or at least after the first block that calls `LoginContext()` succeeds, instead of repeating it in lines 414, 423, 428, 433, and 437.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
