On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < ch...@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > All, > > I haven't updated my local working copies of Tomcat source since the > move to Git. I'm going to do that, now, and I'm looking for advice. > > Specifically, which repo is "better" -- gitbox or GitHub? I'm guessing > the its all go to the same place eventually. Should committers use > gitbox for direct-commits? If I use GitHub, will my commits require > some other review? Do I have to link my GitHub account with my ASF > LDAP id? Is one of them reliably faster? > I use github personally. No commit review is required (but for example I used a PR for larger NIO changes, although in the end I didn't really get any feedback). Setting up the account is needed. I failed to do it, and Mark told me I needed three green ticks there: https://gitbox.apache.org/setup/ Rémy > > Some guidance would be appreciated. > > Thanks, > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/GQ4ACgkQHPApP6U8 > pFgOgRAAyJwFf1rJw9TjQDPqeGekcSzchfflAxplYu6F5o8GFvwkxDeVzHgxGXe8 > Z9t5Oq+Fonmj62rvepxxIarXTTqRCqpsmRIYTzZ8LXwMzlBuZIOeM6ilTijo5HgG > YDWocwLOY7cSIPXtqSBa7zDlloO27drBnb14kadoXJRpqBmwQnssOKOU2hInKzhJ > /SJBp7r//d1tVYSo4J1wRqKigOi8RojafqM1+rh61L1CJlBVK9PCNjdzeP/ewm3l > TBVWekhqDWTXcogEJ7PsxH+zPrfp5EDG03tAl3q7nho/yA1MN0XwTjw3hxbHPCg9 > pKZ+UJzCQpczsJTl5hxR1BemVGZHsReFTZyUEl1AEJDxeg8bXiPtI6AlIN3fYOjP > eJC8kZcoH4Jcge767DuOPQCc1uPyrR1cINl7ajRGdeU1nGTUhwgjZjDRB1eiCTVn > glzK9o88/mpPNEv3ruP/LdnLlj6so+ax4bokxqfnfrBzInYx+jeWiROY/HKik1sA > ysCOEg4tvNazaop26xDMJ5MNROUVcmhd+v2CbM8nZh+6nOoigf8xbRLgT6iJUcDp > 2CgJnWkSIIzadaG4N6CaCHDs03/9jkgDio00nQNDrVS9ufTGlf618bsUHl+Z9wWx > BMo/cLoKOvPasRRIkJRtEzm2VEp4CiPCMq+SLNuiwqkpZ25MRP0= > =1wFC > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
