On Tue, Apr 23, 2019 at 4:29 PM Christopher Schultz < ch...@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Rémy, > > On 4/23/19 10:07, Rémy Maucherat wrote: > > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > > All, > > > > I haven't updated my local working copies of Tomcat source since > > the move to Git. I'm going to do that, now, and I'm looking for > > advice. > > > > Specifically, which repo is "better" -- gitbox or GitHub? I'm > > guessing the its all go to the same place eventually. Should > > committers use gitbox for direct-commits? If I use GitHub, will my > > commits require some other review? Do I have to link my GitHub > > account with my ASF LDAP id? Is one of them reliably faster? > > > > > >> I use github personally. No commit review is required (but for > >> example I used a PR for larger NIO changes, although in the end I > >> didn't really get any feedback). > > So did you fork the Tomcat project and you commit to your fork with > PRs usually? Or just for some stuff? > I did fork and I use it to do big stuff [this way I can accidentally trash the repo without too many problems too ;) ]. For small stuff I simply use the main repo instead. Rémy > > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/IV0ACgkQHPApP6U8 > pFgUFRAAmQLAO8Tn2eKDkcru+PptsybUG1aNYDpRAmAyARAZuu6m50E8HkS0urZ9 > ZlYI4WN9SN6TZuoimnhJp8GzEmoX3nKkhMuGqvxsKLvM+QG7iEkfN1/hisf2/8im > C7exCA43U5TImja6Z+TaXZIV1ZFdoN5dbSzHdj+nACU0gctpjE+jurZ16unRdNCZ > ZlNZwJen2wKCDwmk9dedAHrVuK7mGgoNkkxj/gqeBimuVeqKSwt/85wGDG/tkqRv > 8JVe1OhiP/48t1T5P2cMURSUjRYsLeyqRNPjHzU+Bgi1eK/mvACqzDvRNnixU8l/ > ZjhZGksqBTIBkDEY7C39JM0tDqjW5/N4CBovWBsM4ONAkSGiqzSKuUCn9hEGqBkq > t3RsWg6LJ3GfT40F3xXHhE2Z/txW5wZ6qrB9vozbbPHExCPAsRCbgQ3WfW8DxxT/ > Wt7f+mdjGGYCmkiVsWG7+MimK1po14ANkBnE+Ylo9zd2GH6W29AC4aDOOuROOq2S > DLFhAlw9WxaioqtRE6mhDdadzAV0HfEnRDouZb9Ma6M7DfXoFE1BuQ7cQQeF8ItZ > FZ1VyiV5WOFu7+SHtePx+R6nFfsBpLNFoIEdisMn0WbTiGgoQGyJDlxazAQnuCFx > tKIsIDSDOOPbW8XL2bT96GpELAXFjcoOvchUh1dvblcM0Ir4DYM= > =i8Yc > -----END PGP SIGNATURE----- >
