[tomcat] 01/02: Fix SpotBugs false positive

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 5c026aad80ed73b32e9aa230429c948d0928e9a4
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri May 3 18:40:28 2019 +0100

    Fix SpotBugs false positive
---
 res/findbugs/filter-false-positives.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/res/findbugs/filter-false-positives.xml 
b/res/findbugs/filter-false-positives.xml
index 30ee367..c7239f2 100644
--- a/res/findbugs/filter-false-positives.xml
+++ b/res/findbugs/filter-false-positives.xml
@@ -961,6 +961,13 @@
     <Bug code="Dm" />
   </Match>
   <Match>
+    <!-- As per the comment, FileSystems.getDefault() does have a
+         side-effect. -->
+    <Class name="org.apache.juli.logging.LogFactory"/>
+    <Method name="&lt;init&gt;"/>
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
+  </Match>
+  <Match>
     <!-- Reference.equals() implementation correctly handles sub-classes -->
     <Class name="org.apache.naming.ServiceRef" />
     <Pattern code="EQ_DOESNT_OVERRIDE_EQUALS" />


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org