On Fri, May 17, 2019 at 6:27 PM Mark Thomas <[email protected]> wrote:
> On 17/05/2019 17:25, [email protected] wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new 21ee1c0 Add comment to unreachable code > > 21ee1c0 is described below > > > > commit 21ee1c0b33aed7908a7aa5f415ff8775cfd92119 > > Author: Mark Thomas <[email protected]> > > AuthorDate: Fri May 17 17:25:09 2019 +0100 > > > > Add comment to unreachable code > > > > Identified by Coverity Scan > > --- > > java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java > | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java > b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java > > index 0cd91ef..cdf0e82 100644 > > --- > a/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java > > +++ > b/java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java > > @@ -81,6 +81,7 @@ public class WsRemoteEndpointImplServer extends > WsRemoteEndpointImplBase { > > } else { > > this.handler = handler; > > if (timeout > 0) { > > + // TODO This block is unreachable > > It wasn't immediately obvious to me what to do with this so I added a > comment as a marker. > I don't remember what I meant to do there. I will investigate and fix it. Rémy
