On Wed, May 29, 2019 at 12:26 PM Mark Thomas <ma...@apache.org> wrote:
> On 29/05/2019 08:46, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new b510524 Move ADD_CHILD_EVENT to before the optional container > start > > b510524 is described below > > > > commit b51052483ec3687c6b4db05288d7546d8431eaf0 > > Author: remm <r...@apache.org> > > AuthorDate: Wed May 29 09:45:54 2019 +0200 > > > > Move ADD_CHILD_EVENT to before the optional container start > > > > Since child start is optional and may be delayed, container listeners > > already had to handle this situation (and the mapper indeed does). As > > the (correct) sequence is now add to collection -> add_child_event -> > > start, on stop it is updated to stop -> remove_child_event -> remove > > from collection (for consistency, in practice it is unlikely to make > any > > difference. > > Revert the addition of two container events. > > Thanks Mark for the review and the comment. > > Thanks for making those changes. > No problem, I first had to convince myself this couldn't break anything. So we're still fixing Tomcat 4.0 issues :) Rémy
