On Wed, Jul 3, 2019 at 10:42 PM Mark Thomas <ma...@apache.org> wrote:
> On 03/07/2019 20:46, ma...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new fffb087 Quick fix for poller issue reported on users list > > fffb087 is described below > > > > commit fffb08790e642e03f00c5f96a3a61ee09a2c8342 > > Author: Mark Thomas <ma...@apache.org> > > AuthorDate: Wed Jul 3 20:44:41 2019 +0100 > > > > Quick fix for poller issue reported on users list > > In terms of the slightly less quick fix... > > The code makes reference to two pollset size limits. One is 62 and the > other is 1024. As far as I have been able to determine from reviewing > the APR archives both these limits apply only to Windows. > > The 62 limit seems to date back to Windows NT and the 1024 limit is XP / > Server 2003. > > Given that the oldest currently supported Windows operating systems are > Windows 7 / Server 2008 SP2 then I think it is safe to remove the > multiple poller code from the APR connector. > > Any objections? My current thoughts are to do this refactoring after the > July round of releases. > +1 (same as for NIO) Yes, old OSes brought significant limitations, and the code adds unwanted complexity. Rémy
