https://bz.apache.org/bugzilla/show_bug.cgi?id=63689
Bug ID: 63689
Summary: Variable DISPLAYNAME in service.bat is empty instead
of containing service display name.
Product: Tomcat 9
Version: 9.0.24
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Packaging
Assignee: dev@tomcat.apache.org
Reporter: tschoen...@am-soft.de
Target Milestone: -----
service.bat from Tomcat 9.0.24 contains the following line:
> --DisplayName "%DISPLAYNAME%" ^
The problem is that this variable is used only ones and never defined anywhere.
The same named file in Tomcat 8.0.53 additionally uses lines like the
following:
> set SERVICE_NAME=%1
> set DISPLAYNAME=Apache Tomcat 8.0 %1
While most parts of the service are registered properly in Tomcat 9, it's not
visible in the GUI service manager started using services.msc in the end. The
problem was introduced in Bug 63285 in the following commit:
https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2
DISPLAYNAME was available before and got removed during C&P some lines of code:
> if "x%1x" == "x--userx" goto runAsUser
> set SERVICE_NAME=%1
> set DISPLAYNAME=Apache Tomcat @VERSION_MAJOR_MINOR@ %1
> shift
https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2L111
Now:
> if "x%1x" == "x--userx" goto runAsUser
> set SERVICE_NAME=%1
> shift
https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2R55
Tomcat 8.5.45 has the same problem.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
