On 25/09/2019 21:39, ma...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new bfff085 Fix test failures with APR/native.
> bfff085 is described below
My ideas with the blocking status locks didn't work as well as I hoped.
I could only fix the error if shutdown waited for all in-progress
blocking reads to complete or timeout. Given there are some WebSocket
scenarios that have very long blocking reads that didnlt seem like a
good idea.
I think the best thing to do is aim to minimise the chances of this
crash as much as practical. Given the tentative plan to remove native
I/O in Tomcat 10 I don't think it is worth spending time on the
significant refactoring that would be required for a more reliable solution.
Mark
>
> commit bfff085526f4c3625316be311ca5b3dee41d83b3
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Wed Sep 25 21:39:30 2019 +0100
>
> Fix test failures with APR/native.
> ---
> test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java
> b/test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java
> index 86e574e..a3a22d9 100644
> --- a/test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java
> +++ b/test/org/apache/coyote/http11/filters/TestChunkedInputFilter.java
> @@ -404,6 +404,7 @@ public class TestChunkedInputFilter extends
> TomcatBaseTest {
> client.connect();
> try {
> client.processRequest();
> + client.disconnect();
> } catch (Exception e) {
> // Socket was probably closed before client had a chance to read
> // response
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
