--- Comment #5 from Guoxiong Li <> ---
I once submitted a PR to solve a issue. But the PR was not good enough to merge
so that the committer solved the issue by himself and closed my PR without
merging. As a result, I attach the patch to this BZ for committers to review
and comment this time so that I can modify my patch and avoid my PR to be

It is better for committer to comment, give some recommendation and let the PR
submitter to modify the PR instead of doing similar thing by themselves after
reviewing the PR.

Maybe the situation of my previous PR happened by accident and is not the
typical review process. I will choose only one way(patch or PR) to contribute
in the future according to your suggestion which could avoid repeat. In this
BZ, I will just use the patch file and won't use PR.

You are receiving this mail because:
You are the assignee for the bug.
To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to