markt-asf commented on issue #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222#issuecomment-550298013 This appears to be a purely cosmetic change. Such changes can make back-porting more difficult unless the change is back-ported to all currently supported versions. The change makes this class inconsistent with similar code throughout the Tomcat code base. Changes such as this carry the risk of introducing regressions. Unless a good reason can be provided for applying this, I am leaning towards closing this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
