markt-asf commented on a change in pull request #225: BZ 63681: Introduce
RealmBase#authenticate(GSSName, GSSCredential) an…
URL: https://github.com/apache/tomcat/pull/225#discussion_r350763014
##########
File path: java/org/apache/catalina/Realm.java
##########
@@ -116,6 +118,17 @@ public Principal authenticate(String username, String
digest,
public Principal authenticate(GSSContext gssContext, boolean storeCreds);
+ /**
+ * Try to authenticate using a {@link GSSName}
+ *
+ * @param gssName The {@link GSSName} of the principal to look up
+ * @param gssCredential The {@link GSSCredential} of the principal, may be
+ * {@code null}
+ * @return the associated principal, or {@code null} if there is none
+ */
+ public Principal authenticate(GSSName gssName, GSSCredential
gssCredential);
+
Review comment:
Or...
Add method with default implementation to `Realm` in 9.0.x and add
`GSSRealm` to 7.0.x and 8.5.x, implemented in `RealmBase` and marked as
deprecated in 8.5.x. with removal in 9.0.x.
I'm neutral at this point on whether `GSSRealm` needs to extend `Realm`.
That gets everything in place one major version earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
