On 30/11/2019 21:11, Igal Sapir wrote: > Mark, > > On 11/28/2019 11:46 AM, Mark Thomas wrote: >> Hi all, >> >> I have pushed an initial set of patches for Jakarta EE 9 here: >> https://github.com/markt-asf/tomcat/tree/jakarta >> >> The current status is: >> - All the packages changing in Jakarta EE 9 have been renamed >> - Any associated constants, service loader files etc. have also been >> renamed >> - It builds >> - The unit tests pass (excluding those that depend on JSTL - more on >> that below) >> - A basic smoke test passes >> >> Please try and build it, take it for a spin and report back on this >> thread if you find any issues. > > First issue I noticed when trying to build on Windows: > > compile: > [javac] Compiling 1727 source files to > E:\Workspace\test\tomcat-jakarta\output\classes > [javac] > E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21: > error: package javax.servlet.http does not exist > [javac] import javax.servlet.http.HttpServletRequest; > [javac] ^ > [javac] > E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122: > error: cannot find symbol > [javac] public static boolean isSameOrigin(HttpServletRequest > request, String origin) { > [javac] ^ > [javac] symbol: class HttpServletRequest > [javac] location: class RequestUtil > [javac] Note: Some input files use or override a deprecated API. > [javac] Note: Recompile with -Xlint:deprecation for details. > [javac] 2 errors > > BUILD FAILED > E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the > compiler error output for details.
Sorry. My error. When I rebased the branch I forgot to check if any additional changes were required. I've fixed this now. Note I used a force push to try and keep to the one commit per package I used originally. Should be OK now. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
