https://bz.apache.org/bugzilla/show_bug.cgi?id=63981
Bug ID: 63981
Summary: False-positive warning logged when
Registry.disableRegistry is called and the registry
has already been disabled
Product: Tomcat 9
Version: 9.0.x
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Util
Assignee: dev@tomcat.apache.org
Reporter: awilkin...@pivotal.io
Target Milestone: -----
Calling org.apache.tomcat.util.modeler.Registry.disableRegistry() assigns an
instance of NoDescriptorRegistry to the static registry field. Subsequent
invocations then log a warning that states that the registry cannot be disabled
as it has already been initialised. These feels like a false-positive to me
when registry is an instance of NoDescriptorRegistry. To avoid the unwanted
warning, could the check be changed to something like the following:
if (registry == null) {
registry = new NoDescriptorRegistry();
} else if (!registry instanceof NoDescriptorRegistry) {
log.warn(sm.getString("registry.noDisable"));
}
This would improve log output in integration tests using embedded Tomcat where
Tomcat may be initialised multiple times.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
