markt-asf commented on a change in pull request #227: Unit test FileStore utility methods URL: https://github.com/apache/tomcat/pull/227#discussion_r352785597
########## File path: test/org/apache/catalina/session/FileStoreTest.java ########## @@ -0,0 +1,78 @@ +package org.apache.catalina.session; + +import org.apache.catalina.Manager; +import org.apache.tomcat.unittest.TesterContext; +import org.apache.tomcat.unittest.TesterServletContext; +import org.apache.tomcat.util.http.fileupload.FileUtils; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.io.File; +import java.io.IOException; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; + Review comment: Avoid static imports please. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
