On 15/01/2020 16:41, Rémy Maucherat wrote:
> On Wed, Jan 15, 2020 at 5:35 PM Mark Thomas <ma...@apache.org
> <mailto:ma...@apache.org>> wrote:

<snip/>

>     While I was doing this I did wonder about deprecating/removing
>     [get|set]Attribute on Connector (and any other element where we have
>     both [get|set]Attribute() and [get|set]Property(). Thoughts? Something
>     to add to the TODO list?
> 
> 
> Ok, I forgot the real use of that [get|set]Attribute() to be honest.

I've figured it out.

[get|set]Property() (sort of) expects that the property exists. If it
doesn't, setProperty() is a NO-OP and getProperty() returns null, 0 or
equivalent.

[get|set]Attribute allows arbitrary properties to be set on the
Endpoint. I think this was to support TLS implementations that needed
additional properties. But we have moved away from that.

I think we are still OK to deprecate this in 9.x and remove in 10.x but
I'll leave it a few days before doing anything in case.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to