https://bz.apache.org/bugzilla/show_bug.cgi?id=64180

--- Comment #11 from mgrigorov <mgrigo...@apache.org> ---
(In reply to Christopher Schultz from comment #9)
> (In reply to Remy Maucherat from comment #6)
> > This is mostly wontfix as I am certain the request of the reporter is that
> > secretRequired disables the need for the client to send the secret.
> > 
> > 10.0.0-M2, 9.0.32, 8.5.52 and 7.0.101 will now allow setting a secret as "",
> > and it will be treated as it it had not been set (= null). No doc fix was
> > needed, secretRequired was properly documented already.
> 
> Is this how mod_jk/mod_proxy_ajp are working as well?
> 
> For example, in mod_* is it possible to use a "secret" which is the
> empty-string? Or do they also treat empty-secret as "no secret"?

https://github.com/apache/httpd/commit/d8b6d798c177dfdb90cef1a29395afcc043f3c86#diff-8992fe85968a8915e13ad663eb47d62fR206

I.e. if the value is "" it will be set.
If *conn->worker->s->secret is NULL it will set "secret" to NULL, i.e. do
nothing. I haven't coded in C for many years but I have the feeling this 'if'
is not really needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to