martin-g commented on a change in pull request #277: URL: https://github.com/apache/tomcat/pull/277#discussion_r411969053
########## File path: java/org/apache/coyote/Response.java ########## @@ -61,6 +62,11 @@ */ private static final Locale DEFAULT_LOCALE = Locale.getDefault(); + /** + * Helper to log the invalid HTTP/2.0 header error only once per instance + */ + private static AtomicBoolean invalidHeaderWarningEmitted = new AtomicBoolean(false); Review comment: `per instance` of what ? Because you use `static` here, so it is on class loader level. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org