markt-asf commented on issue #269: URL: https://github.com/apache/tomcat/pull/269#issuecomment-617706987
`Collections.unmodifiable[Set|Map|List]` is probably an option in some cases but some (most?) of these instances are returned as part of a public API and if the API doesn't state they are modifiable then we can't use this approach. Probably a discussion for the dev@ list. The approach used in the PR is sound. I just want to review the full diff and then I'll merge it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
