пн, 18 мая 2020 г. в 20:34, Violeta Georgieva <violet...@apache.org>:
>
> I removed the first location because commons-logging 1.1.3 is now available 
> only from the archives.
> So there is no need to check another location.
> Do we intend to update commons-logging version?

1. I am OK for keeping it at 1.1.3, and your patch is a good fix if we
are keeping it at 1.1.3.

2. Personally, I would like it to be updated to 1.2, but
- as we have not done so yet there may be some reason.
- with EOL for 7.0.x coming there is not much interest in such update.

I think that Apache Commons Logging 1.2 does not build a separate
*-adapters.jar, and so our building & shipping of
/extras/tomcat-juli-adapters.jar will be affected.

3. Unrelated to that, the original issue with "downloadfile-2" may
bite someone in the future, as it is used in other versions of Tomcat
as well.

I am glad that I was able to narrow it down to a behaviour change in Java.

I suspect that it is a deal with how redirects are followed. Maybe it
is a deal with http -> https redirection. (As 'base-apache.loc.1'
value uses http:) I wonder whether the behaviour differs for GET vs
HEAD requests.

На пн, 18.05.2020 г. в 19:29 Konstantin Kolinko <knst.koli...@gmail.com> написа:
> >
> > пн, 18 мая 2020 г. в 16:20, Violeta Georgieva <violet...@apache.org>:
> > >
> > >
> > >
> > > На пт, 8.05.2020 г. в 11:03 Rainer Jung <rainer.j...@kippdata.de> написа:
> > > >
> > > > It seems commons-logging 1.1.3 is no longer part of the mirrors (only in
> > > > the archive). I had to use
> > > >
> > > > commons-logging.version=1.2
> > > > commons-logging-src.checksum.value=ce977548f1cbf46918e93cd38ac35163|0a134d01e9aeb09b33f4c7450fb41abb7bed9db6
> > > >
> > > > instead of
> > > >
> > > > commons-logging.version=1.1.3
> > > > commons-logging-src.checksum.value=e8e197d628436490886d17cffa108fe3|95f0805de0be927c42f5f6eb14b643cb37e7caad
> > > >
> > > >
> > > > to successfully build.
> > >
> > > This should be fixed
> > > https://github.com/apache/tomcat/commit/d13d3f6d7bdabab543e134bbf7e29621524db3ca
> > >
> > > Can you try it?
> >
> > The "downloadfile-2" target in build.xml should automatically switch
> > from main server to the archive.
> >
> > IIRC, it relies on a check that does a HEAD request.
> >
> > "base-apache.loc.1" URL in build.properties.default was last changed
> > on 2018-07-30
> >
> > Testing, 7.0.104, it depends on the version of Java:
> > - commons-logging-1.1.3 is correctly downloaded when running with Ant
> > 1.9.14 and Java 8u252 (jdk-8.0.252.09-hotspot from AdoptOpenJDK)
> > - The download fails when running with Java 14.0.1 (OpenJDK from Oracle)
> >
> > In February 2020 I was successfully running the downloads with Java 13
> > (13.0.2? for Tomcat 7.0.100).
> >
> > So the issue is caused by some change in the JDK.
> > [...]

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to