Holomark opened a new pull request #310: URL: https://github.com/apache/tomcat/pull/310
This specific string is used to produce the context list in the text-based manager (`/manager/text/list`) and the spaces are breaking the tools that rely on it. [Usage in the ManagerServlet](https://github.com/Holomark/tomcat/blob/21d2000c99134b7ec54424ea210cf9b2fd6aae38/java/org/apache/catalina/manager/ManagerServlet.java#L1079) For instance, the cargo maven plugin (https://codehaus-cargo.github.io/cargo/Maven2+plugin.html), when trying to undeploy a project attempts first to find it in the list. If Tomcat's host system is configured in French, cargo will receive an incorrect input and infer that it is not currently deployed in Tomcat, even if it is. That specific bug is how I became aware of the problem. The commit that introduced those specific spaces invoked the french grammar; that is correct but this line is not a piece of natural language and those rules do not apply. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
