markt-asf commented on a change in pull request #323:
URL: https://github.com/apache/tomcat/pull/323#discussion_r458009648
##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
- jakarta.ejb-api,\
- jakarta.mail,\
- jakarta.persistence-api,\
- jakarta.xml.rpc-api,\
- java.xml.ws'
+ jakarta.ejb.api,\
+ jakarta.mail.api,\
Review comment:
Jakarta Mail has opted for `jakarta.mail`
##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
- jakarta.ejb-api,\
- jakarta.mail,\
- jakarta.persistence-api,\
- jakarta.xml.rpc-api,\
- java.xml.ws'
+ jakarta.ejb.api,\
+ jakarta.mail.api,\
+ jakarta.persistence.api,\
+ jakarta.xml.rpc.api,\
+ jakarta.xml.ws.api'
Review comment:
Jakarta XMl WS opted for `jakarta.xml.ws`
##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
- jakarta.ejb-api,\
- jakarta.mail,\
- jakarta.persistence-api,\
- jakarta.xml.rpc-api,\
- java.xml.ws'
+ jakarta.ejb.api,\
Review comment:
Jakarta Enterprise Beans 4.0.0-RC2 does not define a module name so I
think we are OK with this for now.
##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
- jakarta.ejb-api,\
- jakarta.mail,\
- jakarta.persistence-api,\
- jakarta.xml.rpc-api,\
- java.xml.ws'
+ jakarta.ejb.api,\
+ jakarta.mail.api,\
+ jakarta.persistence.api,\
Review comment:
Jakarta Persistence has opted for `jakarta.persistence`
##########
File path: res/bnd/jaspic-api.jar.tmp.bnd
##########
@@ -35,9 +35,9 @@ Provide-Capability: \
Implementation-Vendor=Apache Software Foundation
-jpms-module-info: \
- jakarta.security.enterprise;\
+ jakarta.security.enterprise.api;\
Review comment:
The most recent RC (2.0.0-RC2) doesn't define a module name so this
should be OK for now.
##########
File path: res/bnd/annotations-api.jar.tmp.bnd
##########
@@ -35,9 +35,9 @@ Provide-Capability: \
Implementation-Vendor=Apache Software Foundation
-jpms-module-info: \
- jakarta.annotation;\
+ jakarta.annotation.api;\
access=32;\
version=${annotation.spec.version}
-jpms-module-info-options: \
- jakarta.annotation;\
+ jakarta.annotation.api;\
substitute=annotations-api
Review comment:
This change is not required. Jakarta Annotation API has chosen
`jakarta.annotation`
##########
File path: res/bnd/catalina.jar.tmp.bnd
##########
@@ -55,15 +55,15 @@ Export-Package: \
access=32;\
version=${Bundle-Version};\
modules='\
- jakarta.ejb-api,\
- jakarta.mail,\
- jakarta.persistence-api,\
- jakarta.xml.rpc-api,\
- java.xml.ws'
+ jakarta.ejb.api,\
+ jakarta.mail.api,\
+ jakarta.persistence.api,\
+ jakarta.xml.rpc.api,\
Review comment:
XML RPC has been dropped in Jakarta EE 9. We'll need to clean that up in
Tomcat. I guess this one can stay as is for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
