-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Filip,
On 7/21/20 11:22, fha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > fhanik pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this > push: new c08bf81 Avoid reflection for default instantiation > c08bf81 is described below > > commit c08bf81f0db7742779ab0c5da45818dde8465d34 Author: Filip Hanik > <fha...@pivotal.io> AuthorDate: Mon Jul 13 12:43:55 2020 -0700 > > Avoid reflection for default instantiation > > (Most commonly used codepath) > > Avoid having to load APR classes in the Connector > > Ensure that IntrospectionUtils can call setProperty on > PersistentProviderRegistrations --- > .../auth/message/config/AuthConfigFactory.java | 8 ++- > .../jaspic/PersistentProviderRegistrations.java | 12 ++++- > java/org/apache/catalina/connector/Connector.java | 8 +-- > .../apache/catalina/core/AprLifecycleListener.java | 32 > +++++------- java/org/apache/catalina/core/AprStatus.java | > 60 ++++++++++++++++++++++ > java/org/apache/catalina/core/StandardHost.java | 4 +- > java/org/apache/catalina/loader/WebappLoader.java | 4 ++ > java/org/apache/catalina/startup/Tomcat.java | 8 ++- 8 files > changed, 109 insertions(+), 27 deletions(-) > > diff --git > a/java/jakarta/security/auth/message/config/AuthConfigFactory.java > b/java/jakarta/security/auth/message/config/AuthConfigFactory.java > index d0e1cbd..6f02fde 100644 --- > a/java/jakarta/security/auth/message/config/AuthConfigFactory.java > +++ > b/java/jakarta/security/auth/message/config/AuthConfigFactory.java > @@ -72,8 +72,12 @@ public abstract class AuthConfigFactory { // > this class. Note that the Thread context class loader // should not > be used since that would trigger a memory leak // in container > environments. - Class<?> clazz = > Class.forName(className); - return > (AuthConfigFactory) clazz.getConstructor().newInstance(); + > if > (className.equals("org.apache.catalina.authenticator.jaspic.AuthConfig FactoryImpl")) > { Why not use AuthConfigFactoryImpl.class.getName()? It may help in the future with refactoring. - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl8YXgIACgkQHPApP6U8 pFgHmA/8CweFBvWtEn14ZzUZHkA/7HVaLPG6r7Y4qzkcrzJfQImYzV7E0x3NL59m fDagGxJrxugESEKf3HLmq5VIzAlemkbPxYQ7S4KaUJVHbRW/MH9zPVzbvAVXy4Gm CIpVF/QoXftJ9WYsMkwFFu8ZeRsUQSJ5Z4eFXmHgOzDSj42vUR7VDsFXmpoqdIpC jp0CV9p+XyfAcvtsJXnTKKmDGFV7liH4d38mz8wNLFw1yFk8jswHeyzzy+6u9QVu fFno1AZ67UWjeOlMz+kQ4S9n3X+irT03Qpc8+kvWDibnEDYuHivvhvROWOn4ja92 dyF+6YZxOGIf4QHwM0BHL+8IzrcodB15j7Iv0Fw9VKrJvcj55qZTerHvOkiwUDQF 1vsiqPtOEWrE4q87Y7aev3WBpRWfxQFu50IQNIAvPwiBmT9mj+3iztq46m5CTtnt zjfdzxEMF5n74L+2u+CPIekngJ8i0RJOkq4UGrJmXpbX/82q+eN+TDws6GchRquG 3Hr2EgC3oocITMTbu+5ZjvbBVAh30VhqlOF1GwO8YSBIgvNUyPvIqZXK4Re9gjYm BSRHl2juGFP3d1OSkdimWBkBc8MHx3QOkcCOzZYgPg3mdAq7beqKgh/DTvqQd5D8 MXGe4cgfHoOEY0X53K/qG1KXcIntRXab9Nue8GriGC9M7oMWgIM= =48+3 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
