This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2f19d16 Refactor Default servlet to simplify support for custom ETag
formats
2f19d16 is described below
commit 2f19d166d4f095d0715bcefd294e87a83f7661ac
Author: Mark Thomas <[email protected]>
AuthorDate: Mon Aug 10 17:19:52 2020 +0100
Refactor Default servlet to simplify support for custom ETag formats
---
.../apache/catalina/servlets/DefaultServlet.java | 25 +++++++++++++++++-----
.../apache/catalina/servlets/WebdavServlet.java | 2 +-
webapps/docs/changelog.xml | 5 +++++
3 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/java/org/apache/catalina/servlets/DefaultServlet.java
b/java/org/apache/catalina/servlets/DefaultServlet.java
index 5ffc548..466f1df 100644
--- a/java/org/apache/catalina/servlets/DefaultServlet.java
+++ b/java/org/apache/catalina/servlets/DefaultServlet.java
@@ -905,7 +905,7 @@ public class DefaultServlet extends HttpServlet {
String eTag = null;
String lastModifiedHttp = null;
if (resource.isFile() && !isError) {
- eTag = resource.getETag();
+ eTag = generateETag(resource);
lastModifiedHttp = resource.getLastModifiedHttp();
}
@@ -1494,7 +1494,7 @@ public class DefaultServlet extends HttpServlet {
// Ignore
}
- String eTag = resource.getETag();
+ String eTag = generateETag(resource);
long lastModified = resource.getLastModified();
if (headerValueTime == (-1L)) {
@@ -2161,7 +2161,7 @@ public class DefaultServlet extends HttpServlet {
HttpServletResponse response, WebResource resource)
throws IOException {
- String eTag = resource.getETag();
+ String eTag = generateETag(resource);
// Default servlet uses weak matching so we strip any leading "W/" and
// then compare using equals
if (eTag.startsWith("W/")) {
@@ -2222,7 +2222,7 @@ public class DefaultServlet extends HttpServlet {
// The entity has not been modified since the date
// specified by the client. This is not an error case.
response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
- response.setHeader("ETag", resource.getETag());
+ response.setHeader("ETag", generateETag(resource));
return false;
}
@@ -2249,7 +2249,7 @@ public class DefaultServlet extends HttpServlet {
HttpServletResponse response, WebResource resource)
throws IOException {
- String eTag = resource.getETag();
+ String eTag = generateETag(resource);
String headerValue = request.getHeader("If-None-Match");
if (headerValue != null) {
@@ -2323,6 +2323,21 @@ public class DefaultServlet extends HttpServlet {
/**
+ * Provides the entity tag (the ETag header) for the given resource.
+ * Intended to be over-ridden by custom DefaultServlet implementations that
+ * wish to use an alternative format for the entity tag.
+ *
+ * @param resource The resource for which an entity tag is required.
+ *
+ * @return The result of calling {@link WebResource#getETag()} on the given
+ * resource
+ */
+ protected String generateETag(WebResource resource) {
+ return resource.getETag();
+ }
+
+
+ /**
* Copy the contents of the specified input stream to the specified
* output stream, and ensure that both streams are closed before returning
* (even in the face of an exception).
diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java
b/java/org/apache/catalina/servlets/WebdavServlet.java
index 63d352e..b02433d 100644
--- a/java/org/apache/catalina/servlets/WebdavServlet.java
+++ b/java/org/apache/catalina/servlets/WebdavServlet.java
@@ -1994,7 +1994,7 @@ public class WebdavServlet extends DefaultServlet {
generatePropFindResponse(generatedXML, rewrittenUrl, path, type,
propertiesVector,
resource.isFile(), false, resource.getCreation(),
resource.getLastModified(),
resource.getContentLength(),
getServletContext().getMimeType(resource.getName()),
- resource.getETag());
+ generateETag(resource));
}
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e1c8e04..f3bef3f 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -69,6 +69,11 @@
Add a dedicated loader for generated code to avoid dynamic class
loading. (remm)
</update>
+ <add>
+ Refactor the Default servlet to provide a single method that can be
+ overridden (<code>generateETag()</code>) should a custom entity tag
+ format be required. (markt)
+ </add>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
