On 11/08/2020 18:06, Michael Osipov wrote: > Am 2020-08-11 um 18:53 schrieb Mark Thomas: >> On 11/08/2020 17:29, Michael Osipov wrote: >>> Am 2020-08-11 um 16:52 schrieb ma...@apache.org: >> >> <snip/> >> >>>> commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc >>>> Author: Mark Thomas <ma...@apache.org> >>>> AuthorDate: Tue Aug 11 15:27:45 2020 +0100 >>>> >>>> Improve entity tag handling
<snip/> >>> Even an option for this is wrong. I agree that we cannto produce strong >>> ETags by default, but it is now better decoupled and a subclass can >>> handle this. Please retain the semantics as described in RFC 7232. >> >> It isn't possible to retain the semantics of RFC 7232 because Tomcat >> prior to this commit did not implement them. >> >> If you look at the code prior to this commit, any "W/" was stripped from >> the resource ETag and the ETag values in the If-Match header before >> comparison. The result of doing that is that the comparison is >> effectively a weak one rather than a strong one. >> >> The option is required to preserve backwards compatibility. > > Granted. This ultimately means that Tomcat 10 should remove this cruft > and be RFC-compliant. For previous versions a comment about behavioral > change/deprecation should be added too. > > Can we agree on this? Maybe. I'd lean towards changing the default in Tomcat 10 to the RFC 7232 compliant behaviour with a view to removing the option in Tomcat 11 if the change in default doesn't trigger a bunch of user questions / bug reports etc. If the consensus is to remove the option immediately in Tomcat 10 I can live with that but my preference would be to change the default in 10 and remove in 11. What do others think? Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
