stokito commented on pull request #337:
URL: https://github.com/apache/tomcat/pull/337#issuecomment-672777683
yes, you are right and I wanted to discuss it latter. The PR fixes only one
specific problem + small refactoring.
The problem that I see is that the new `useWeakComparisonWithIfMatch` flag
is not complaint with RFC because it always should be strict.
An origin server MUST use the strong comparison function when comparing
entity-tags for If-Match (Section 2.3.2), since the client intends this
precondition to prevent the method from being applied if there have been any
changes to the representation data.
In fact as far I understood the weak comparison for `If-Match` was
implemented by mistake in scope of b26ad77f659de34d49dda5a248566a38383cec0e.
And this happened recently. That means that in fact here we making the bug as a
feature. This may have sense if there is a lot of users who used this behavior
but in fact we definitely haven't any of them.
Did I miss something? Can we simplify logic and and inline
useWeakComparisonWithIfMatch as a false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
