On Mon, Aug 31, 2020 at 8:39 PM Mark Thomas <ma...@apache.org> wrote:
> On 31/08/2020 17:17, David Blevins wrote: > > Hey All, > > > > Curious if there would be any willingness to change the default of this > to true for Tomcat 10 prior to final release. > > > > - > https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/core/StandardServer.java#L195 > > Unlikely based on the information provided. Making the utility threads > daemon threads looks like a hack to work around a problem elsewhere. I'm > more interested in tackling the root cause. > I added the option because "you never know", but I don't quite see why it's a good idea to interrupt this sort of work. > > > The current default prevents a JVM shutdown and effectively means > setting this to either true or false has no effect: > > > > - > https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/startup/Catalina.java#L91 > > In what circumstances? I haven't observed any issues with non-clean > shutdowns when running from the command line or as a service. > David's argument here isn't relevant since any other non daemon thread can cause the await setting to be ineffective. Rémy > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
