kamnani opened a new pull request #351: URL: https://github.com/apache/tomcat/pull/351
This is a redo of Previous CR : https://github.com/apache/tomcat/pull/331 These changes enable the compiler to remove excess white space from the JSP files & thus reduce the JVM metadata _(Constant whitespace in a JSP is passed unchanged to the client browser (indentations, newlines, etc.). This results in bloated constant strings, and general waste in I/O operations. Trimming this whitespace results in smaller constants)._ This can be controlled by providing context init params inside web.xml file. Example attached. Based on your previous suggestions the following changes have been made: 1) Pre tags will be left untouched - to protect the behavioral changes on that tag. 2) By default this remains false, and thus will not affect any other supporting feature (SMAP for instance as suggested in previous CR) . 3) The flag is now initialized as a context param as mentioned in the example below. Apologies in case something is missed out. If any official documentation is required, can you attach the links on the PR? ``` <web-app> <context-param> <param-name>JSPWhiteSpaceTrimming</param-name> <param-value>true</param-value> </context-param> </web-app> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
