https://bz.apache.org/bugzilla/show_bug.cgi?id=64715
--- Comment #6 from Robert Rodewald <robert.rodew...@kopsis.com> --- (In reply to Mark Thomas from comment #5) > - It doesn't handle all combinations of > - Constructor with/without Context I don't think a constructor for CallbackHandlerImpl without Context is needed. As this is a Tomcat internal class and AuthenticatorBase can always provide a context with realm (this is stated in the usage constraints of AuthenticatorBase). Or am I misinterpreting you? > - Class defined in web app / in container That's a case I don't seem to understand. Could you please explain? > - The call to the "with Context" constructor will always fail (no Context) Ugh. Missing argument. I'll change this when the other fixes are clear. > - Use of an interface would be cleaner. The Contained interface is a good > fit. Are you suggesting to pass the Realm (which is a Contained) to the CallbackHandler? Wouldn't that break dynamic configuration through JMX? I could use Container though. I also saw that minor modifications to the tests will be necessary too. In addition I would add one or two tests for the Callbacks. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
