martin-g commented on a change in pull request #355:
URL: https://github.com/apache/tomcat/pull/355#discussion_r485590380



##########
File path: java/jakarta/el/ELContext.java
##########
@@ -139,6 +140,10 @@ public void setLocale(Locale locale) {
      * @since EL 3.0
      */
     public void addEvaluationListener(EvaluationListener listener) {
+        if (listeners == null) {

Review comment:
       Is it possible that this method is called by multiple threads ? In that 
case you will need to add locking here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to