stiemannkj1 commented on pull request #358:
URL: https://github.com/apache/tomcat/pull/358#issuecomment-690805345
@rmaucher, I think you are right about `declareRoles` and Servlet 4.0
methods. However, I think only the following methods would be broken:
* `doPrivileged("declareRoles", new Object[]{roleNames});`
* `doPrivileged("setSessionTimeout", new Object[] {
Integer.valueOf(sessionTimeout) });`
* `doPrivileged("setRequestCharacterEncoding", new Object[] { encoding });`
* `doPrivileged("setResponseCharacterEncoding", new Object[] { encoding });`
Other methods that have no args won't have this issues, and anything that
calls the 3-arg `doPrivileged` method won't have this issue.
Maybe I'll add some tests and fix the other methods as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
