rmaucher commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-750141172
I added the feature for NIO, since it wasn't too difficult using https://openjdk.java.net/jeps/380 . Testing with curl works fine, I'll add a test in the testsuite next. It does have specific unlock accept, some compatibility code for port/address annoyances ("TCP local addresses" for access logs, JMX name, connector name), and the port attribute becomes optional. This cannot be added to NIO2 since the feature is not available. Some possible changes: - The permission attribute, is it really useful ? - Reflection is used for this attribute for now since this is NIO only - The socket is not deleted on shutdown (although the channel is closed) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
