On 27/01/2021 09:05, Konstantin Kolinko wrote: > ср, 27 янв. 2021 г. в 11:14, Mark Thomas <ma...@apache.org>: >> >> On 27/01/2021 07:52, Mark Thomas wrote: >>> On 27/01/2021 04:51, build...@apache.org wrote:
<snip/> >>>> BUILD FAILED: failed compile >>> >>> This is because the CI system uses NSIS 2.something to work around an >>> incompatibility with NSIS 3 and wine. That was a while ago. I guess it >>> is worth checking if the issue still exists as a first step in deciding >>> how to handle this. >> >> Woot! I don't see the issue locally. I'll get the CI system updated. >> This also opens up the option of building releases on Linux. > > FYI: > I added the "Unicode true" command to the .nsi file as NSIS 3.05 > deprecated support for ANSI. [1] > When I build with the current version (3.06.1), it prints a warning > unless that line is added. > > Looking at their changelog [1], it says that starting with the next > version (3.07) the default value for "Unicode" command will be changed > to be true, so that explicit Unicode command will not be needed. So > one option is to remove the "Unicode" line and just ignore the > warning. Thanks for the background. That is very helpful. The CI system is currently on Ubuntu 18.04 LTS but testing shows that the latest version of wine-stable available for 18.04.LTS and the latest NSIS 3 are compatible. I have been able to build the installer on the CI box and use it to install a working Tomcat instance on a local Windows VM. I am going to go ahead and remove the hack that kept the CI system using NSIS 2. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
