https://bz.apache.org/bugzilla/show_bug.cgi?id=65136
--- Comment #1 from Manuel Dominguez Sarmiento <m...@renxo.com> --- Comments from Mark Thomas on the Tomcat User List dated January 7th 2021: "Some svn archaeology uncovered this commit comment: "Known issue: locking occurs on an uploaded WAR, for reasons which elude me right now." The method level sync looks like an attempt to ensure that there aren't parallel attempts to deploy a web application to the same path. I can't think of any other reason. But locking on, essentially, the virtual host, seems overly broad. A lock on the deployment path would be sufficient. There are also calls to isServiced(), addServiced() and removeServiced() which look to be trying to do the same thing which have their own issues (not atomic, uses a List rather than a Set). We do need to ensure that we don't get parallel attempts to service the same web application. There is scope for all sorts of bad things to happen if that is possible. Overall, I think this can be fixed but it looks like some API changes are going to be required which makes things a little more complicated. It would be worth you opening a Bugzilla issue for this to make sure it doesn't get forgotten about. The issues with the unsynchronized deployment methods are sufficient - in my view - to class this as a bug rather than an enhancement. Mark" -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
