This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit a79ffed8bded9a68ee17a7c4fba98cb8d8b754b2 Author: Mark Thomas <ma...@apache.org> AuthorDate: Thu May 6 17:37:19 2021 +0100 Remove unnecessary code If an attribute value is null, it must be a named attribute. --- java/org/apache/jasper/compiler/Generator.java | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/java/org/apache/jasper/compiler/Generator.java b/java/org/apache/jasper/compiler/Generator.java index 474ac5c..5100bae 100644 --- a/java/org/apache/jasper/compiler/Generator.java +++ b/java/org/apache/jasper/compiler/Generator.java @@ -2982,17 +2982,14 @@ class Generator { String attrValue = attr.getValue(); if (attrValue == null) { - if (attr.isNamedAttribute()) { - if (n.checkIfAttributeIsJspFragment(attr.getName())) { - // XXX - no need to generate temporary variable here - attrValue = generateNamedAttributeJspFragment(attr - .getNamedAttributeNode(), tagHandlerVar); - } else { - attrValue = generateNamedAttributeValue(attr - .getNamedAttributeNode()); - } + // Must be a named attribute + if (n.checkIfAttributeIsJspFragment(attr.getName())) { + // XXX - no need to generate temporary variable here + attrValue = generateNamedAttributeJspFragment(attr + .getNamedAttributeNode(), tagHandlerVar); } else { - return null; + attrValue = generateNamedAttributeValue(attr + .getNamedAttributeNode()); } } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org