Mark,
On 6/24/21 03:59, Mark Thomas wrote:
On 23/06/2021 20:06, Christopher Schultz wrote:
Mark,
On 6/23/21 13:19, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b9bd126 Simplify - identified by SpotBugs
b9bd126 is described below
commit b9bd12608d3a14ed036a1602f39b148d91fb5489
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Jun 23 18:18:37 2021 +0100
Simplify - identified by SpotBugs > ---
java/org/apache/jasper/runtime/PageContextImpl.java | 17
+----------------
1 file changed, 1 insertion(+), 16 deletions(-)
Will this not end up flushing buffers potentially needlessly early,
converting responses to Chunked and preventing errors from being
reported by committing the response?
No. This flushes the JSPWriterImpl. That flushes any data buffered in
the JSPWriterImpl to the Writer obtained from the HttpServletResponse
but that Writer is not then flushed.
Great, thanks for the explanation.
I realize that THIS patch doesn't do that, but it looks like the
history of the file (c.f. the "Old code" comment) has two different
behaviors depending upon whether the file is being included.
The "Old code" has been commented out for more than 15 years. You'd need
to go back to the 5.5.x svn archives to understand what was going on here.
Glad to see it go, then.
Thanks,
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
