On 19/11/2021 15:29, Christopher Schultz wrote:
Mark,
On 11/18/21 05:10, ma...@apache.org wrote:
> [snip]
+ <attribute name="className" required="true">
+ <p>Java class name of the implementation to use. This class
must implement
+ the <code>org.apache.catalina.WebResourceRoot$CacheStrategy</code>
YUCK
Implement an interface defined as an inner class? If this is intended to
be an extension point for Tomcat, this is a Bad way to do it IMO. Sure,
there is prior art (e.g. Map$Entry) but ... eew.
Any reason not to promote CacheStrategy to a top-level class (interface)?
Yes. This is already part of Tomcat's public interface.
The time for this sort of feedback was 2 weeks ago when the commit that
changed the code was made.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
