Mark,
On 11/27/21 06:31, Mark Thomas wrote:
On 27/11/2021 04:17, Christopher Schultz wrote:
Mark,
On 11/8/21 08:55, Mark Thomas wrote:
On 08/11/2021 12:42, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new b15b713 Switch from Cobertura to JaCoCo for code coverage
b15b713 is described below
commit b15b7130ced07cfe36961531dad4642a422e9500
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Nov 8 12:41:36 2021 +0000
Switch from Cobertura to JaCoCo for code coverage
Thoughts on back-porting this? We don't need to back-port it. The
primary benefit I see is consistency.
I only just read this; sorry for not seeing it earlier in the month.
I don't mind the back-port; I was just curious why you decided to
switch code-coverage tools. I don't recall seeing a discussion on the
list. I'm not demanding such a discussion, it's just that you are
usually very good about asking for feedback before making a tooling
change like that.
I think I mentioned the reasoning somewhere but I can't find it now so I
am happy to provide an explanation here.
The short version is that Cobertura doesn't work with Java 11 and there
was no indication that Java 11 support was going to be available soon.
This has been a problem for a while but I only noticed it when I was
trying to get the builds working on the upgraded BuildBot CI
infrastructure. I did a little research and saw JaCoCo which was a name
a recognised from other ASF projects using it - primarily Commons.
In addition to Java 11 support, a big advantage of JaCoCo is that it can
handle tests running in parallel. That reduces the overnight CI runs
that generate the coverage reports from ~4 hours to ~1 hour.
I've no objection to considering alternatives if folks want to propose
one as I didn't do an exhaustive search. Equally, I'm happy sticking
with JaCoCo.
Thanks for the details.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
