gmshake commented on pull request #461: URL: https://github.com/apache/tomcat/pull/461#issuecomment-987793365
> Ok, I am sorry, I will reference you directly :) I disagree with you, @markt-asf. The class Base64 is used **_directly_** by the clients. Just a couple of examples: [this](https://stackoverflow.com/questions/10744715/how-to-base64-encode-a-java-object-using-org-apache-commons-codec-binary-base64/10747284), and [this](https://www.baeldung.com/java-base64-encode-and-decode#encodingdecoding-using-apache-commons-code), also [this](https://stackoverflow.com/questions/11544568/decoding-a-base64-string-in-java) and e.t.c.) - and, as I already mentioned, Base64 delegates to BaseNCodec, which does not tolerate null. > > @markt-asf I really do not understand why it is so hard to apply this minor, non-breaking change :) As I mentioned above, people are using this API in thier code (it is public b.t.w), so why not make their life easier?) @Mikhail2048 , as @markt-asf has emphasised: > This code is not part of a framework. It is Tomcat's internal API. Applications should not be calling this code. The examples you referenced is `org.apache.commons.codec.binary.Base64`, that is not this one `org.apache.tomcat.util.codec.binary.BaseNCodec`. Be aware the two packages are different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
