This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 3eb4a0a4c544453a543a35d8eb2632bf300b4943
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sun Jan 2 15:33:56 2022 +0000
Back-port fixes for false positives when running via Ant
---
res/spotbugs/filter-false-positives.xml | 36 +++++++++++++++++++++++++++++++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index 7245c93..2307c6e 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -580,6 +580,12 @@
<Bug pattern="DM_EXIT" />
</Match>
<Match>
+ <!-- Genric error handling -->
+ <Class name="org.apache.catalina.startup.Catalina" />
+ <Method name="parseServerXml" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
<!-- Catalina isn't used when embedding -->
<Class name="org.apache.catalina.startup.Catalina" />
<Method name="stopServer" />
@@ -868,6 +874,12 @@
<Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
</Match>
<Match>
+ <!-- Switch fall-though is deliberate -->
+ <Class name="org.apache.coyote.AbstractProcessor"/>
+ <Method name="parseHost"/>
+ <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+ </Match>
+ <Match>
<!-- Use of synchronisation is required to make a sequence of calls in
-->
<!-- one method appear to be atomic.
-->
<Class name="org.apache.coyote.AbstractProcessorLight"/>
@@ -1144,7 +1156,12 @@
<!-- Simpler to catch Exception than to create dummy implementations of the
necessary exception hierarchy -->
<Class name="org.apache.naming.factory.SendMailFactory" />
- <Method name="lambda$0" />
+ <Or>
+ <!-- Latest Eclipse plug-in and latest stand-alone JAR report different
+ method names. -->
+ <Method name="lambda$0" />
+ <Method name="lambda$getObjectInstance$0" />
+ </Or>
<Bug pattern="DE_MIGHT_IGNORE" />
</Match>
<Match>
@@ -1328,7 +1345,10 @@
<Match>
<!-- Fields are used by native code. Tomcat doesn't use them but they are
part of the public API. -->
- <Class name="org.apache.tomcat.jni.Sockaddr" />
+ <Or>
+ <Class name="org.apache.tomcat.jni.FileInfo" />
+ <Class name="org.apache.tomcat.jni.Sockaddr" />
+ </Or>
<Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD" />
</Match>
<Match>
@@ -1727,6 +1747,18 @@
<Bug code="DLS" />
</Match>
<Match>
+ <!-- Exception is caught so any issue is handled -->
+ <Class name="org.apache.tomcat.websocket.WsRemoteEndpointImplBase" />
+ <Method name="sendObjectByCompletion" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
+ <!-- Exception is caught so any issue is handled -->
+ <Class name="org.apache.tomcat.websocket.WsWebSocketContainer" />
+ <Method name="createSSLEngine" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
<!-- Random will be used multiple times. -->
<Class name="org.apache.tomcat.websocket.WsWebSocketContainer"/>
<Method name="generateWsKeyValue"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
