This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 261a939025b2241fcc03e001771649528561c914
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sun Jan 2 15:55:30 2022 +0000
Fix false positives running via Ant
---
res/spotbugs/filter-false-positives.xml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index ef5b601..6527fd8 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -837,6 +837,12 @@
<Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
</Match>
<Match>
+ <!-- Switch fall-though is deliberate -->
+ <Class name="org.apache.coyote.AbstractProcessor"/>
+ <Method name="parseHost"/>
+ <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+ </Match>
+ <Match>
<!-- Use of synchronisation is required to make a sequence of calls in
-->
<!-- one method appear to be atomic.
-->
<Class name="org.apache.coyote.AbstractProcessorLight"/>
@@ -1674,6 +1680,18 @@
<Bug code="DLS" />
</Match>
<Match>
+ <!-- Exception is caught so any issue is handled -->
+ <Class name="org.apache.tomcat.websocket.WsRemoteEndpointImplBase" />
+ <Method name="sendObjectByCompletion" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
+ <!-- Exception is caught so any issue is handled -->
+ <Class name="org.apache.tomcat.websocket.WsWebSocketContainer" />
+ <Method name="createSSLEngine" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
<!-- Random will be used multiple times. -->
<Class name="org.apache.tomcat.websocket.WsWebSocketContainer"/>
<Method name="generateWsKeyValue"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
