This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit e99da3e6542f2189b2655ad0781d6a8ac816a26d Author: Mark Thomas <[email protected]> AuthorDate: Tue Mar 15 17:18:19 2022 +0000 Add additional false positives for test code --- res/spotbugs/filter-false-positives.xml | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml index c9382b5..85ca2a7 100644 --- a/res/spotbugs/filter-false-positives.xml +++ b/res/spotbugs/filter-false-positives.xml @@ -1940,7 +1940,10 @@ <Match> <!-- Return value of latch is intentionally ignored --> <Class name="org.apache.catalina.nonblocking.TestNonBlockingAPI"/> - <Method name="testDelayedNBWrite"/> + <Or> + <Method name="testDelayedNBReadWrite"/> + <Method name="testDelayedNBWrite"/> + </Or> <Bug pattern="RV_RETURN_VALUE_IGNORED"/> </Match> <Match> @@ -2143,13 +2146,17 @@ <Bug code="DE" /> </Match> <Match> - <!-- Non-constant is just a split constant --> <Class name="org.apache.catalina.users.DataSourceUserDatabaseTests"/> <Or> <Method name="testBasicUserRoleDatabase"/> <Method name="testUserDatabase"/> </Or> - <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/> + <Or> + <!-- There is no null check - SpotBugs bug? --> + <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/> + <!-- Non-constant is just a split constant --> + <Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/> + </Or> </Match> <Match> <!-- Concrete Map type not affected --> @@ -2533,4 +2540,10 @@ </Or> <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/> </Match> + <Match> + <!-- There is no null check - SpotBugs bug? --> + <Class name="org.apache.tomcat.websocket.server.TestWsServerContainer" /> + <Method name="testBug58232" /> + <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/> + </Match> </FindBugsFilter> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
