On Wed, Mar 23, 2022 at 9:04 PM Mark Thomas <ma...@apache.org> wrote:
>
> On 23/03/2022 20:01, r...@apache.org wrote:
>
> <snip/>
>
> > diff --git a/java/org/apache/coyote/http2/Http2Parser.java
> > b/java/org/apache/coyote/http2/Http2Parser.java
> > index 5875e28..8c67d84 100644
> > --- a/java/org/apache/coyote/http2/Http2Parser.java
> > +++ b/java/org/apache/coyote/http2/Http2Parser.java
> > @@ -337,7 +337,12 @@ class Http2Parser {
> > }
> > int id = ByteUtil.getTwoBytes(setting, 0);
> > long value = ByteUtil.getFourBytes(setting, 2);
> > - output.setting(Setting.valueOf(id), value);
> > + Setting key = Setting.valueOf(id);
> > + if (log.isDebugEnabled() && key == Setting.UNKNOWN) {
> > + log.warn(sm.getString("connectionSettings.unknown",
>
> The above two lines are inconsistent. The message is at WARN level so
> the isDebugEnabled() test is not appropriate.
Yes, I already spotted it and changed it back.
That was likely intentional and a bit sneaky ...
Rémy
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
